Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown menu rework #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Dropdown menu rework #249

wants to merge 1 commit into from

Conversation

TaranP1
Copy link
Contributor

@TaranP1 TaranP1 commented Dec 20, 2024

No description provided.

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for hackillinois ready!

Name Link
🔨 Latest commit 64aa9a7
🔍 Latest deploy log https://app.netlify.com/sites/hackillinois/deploys/676a5f5b28646c000812ac0b
😎 Deploy Preview https://deploy-preview-249--hackillinois.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

We have a lot of nice components from past years - no need to re-invent
the wheel on this one.
@Timothy-Gonzalez
Copy link
Member

Timothy-Gonzalez commented Dec 24, 2024

Previous solution used bootstrap - the problem with bootstrap is that adding that css will mess up everything else - you can't really do partial bootstrap.

If you ever find yourself creating a component, stop. There is enough js libraries in the world. react-select is perfect for our usecase (searchable dropdown), and what we used in the past. While rewriting some parts of the website was good, we shouldn't rewrite everything from scratch.

Changes:

  • Changed dropdown to use react-select + formik
  • Changed race to be an array
  • Moved email to be after names

Misc bug (unrelated to change): all pages are the same form, so touched gets set to true for all fields after first submit. somehow we need to make each page a separate form so this doesn't happen. Example of why this is an issue: On education page, selecting on option marks everything else as wrong even though they haven't been touched yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants