Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update versions and added terms #3

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

ypriverol
Copy link
Contributor

No description provided.

@ypriverol ypriverol requested a review from mobiusklein May 9, 2024 13:22
@ypriverol ypriverol requested a review from diogobor May 9, 2024 13:49
Copy link
Collaborator

@diogobor diogobor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DSAU is correct.

@ypriverol ypriverol requested a review from lutzfischer May 9, 2024 16:08
synonym: "C2-Urea-NHS-crosslinker" EXACT []
synonym: "Urea-crosslinker C2-succinimide" EXACT []
synonym: "DSAU" EXACT []
property_value: deadEndFormula: "C 13 H 14 N 4 O 9" xsd:string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead end formula makes no sense here. That is only for the hydrolised or otherwise quenched.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
property_value: deadEndFormula: "C 13 H 14 N 4 O 9" xsd:string
property_value: bridgeFormula: "C5 H4 N2 O3" xsd:string
property_value: reactionSites: "2" xsd:nonNegativeInteger
property_value: spacerLength: "7.7" xsd:float

property_value: monoIsotopicMass: "140.02219198" xsd:double
is_a: XLMOD:00005 ! homofunctional cross-linker
relationship: has_reactive_group XLMOD:00101 ! NHS ester
relationship: is_cleavable XLMOD:00067 ! CID cleavable C-S bond
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XLMOD:00067 is also the wrong term here - need to check for the right one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most simple would be XLMOD:00018 ! cleavable by MS2 labile bond

Copy link
Collaborator

@lutzfischer lutzfischer May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only terms that look like they would be accurate are XLMOD:00018 ! cleavable by MS2 labile bond as the most general term or XLMOD:00035 ! CID cleavable (assuming it cleaves in in CID as well).

I don't think we have a term for CO-NH bond cleavable /peptide like cleavage (I assume that is where it cleaves) - we could add a term for that as well (copied from the C-S bond term)

[Term]
id: XLMOD:000174
name: CID cleavable CO-NH bond
def: "Indicates that a cross-linker contains a CID (Collision Induced Dissociation) cleavable peptide bond." [PSI:XL]
is_a: XLMOD:00035 ! CID cleavable
relationship: is_cleavable XLMOD:00018 ! cleavable by MS2 labile bond

But somebody with a better authority on chemical/MS nomenclature would need to decide what name/description to use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants