Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eat larger patches #1698

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Eat larger patches #1698

wants to merge 1 commit into from
+1 −1

Conversation

schluis
Copy link
Contributor

@schluis schluis commented Mar 12, 2025 •
edited by ThagonDuarte
Loading

Why? What?

  • Increases the enlargement_factor for ball candidates
  • Increases the probability, that the ball is completely in the patch for the classifier

Fixes #1695

ToDo / Known Issues

  • Find out, why this is a problem now?!

Ideas for Next Iterations (Not This PR)

  • Search for a root cause and fix it

How to Test

  • Checked it using the replay of the game HULKs vs. DutchNao (2025-03-12-testgame)
  • Have a look at the Ball Candidates Panel in twix

@schluis @ThagonDuarte
larger patches
8122899 
Co-authored-by: Alexander Schmidt <[email protected]>
@schluis schluis enabled auto-merge March 12, 2025 20:25
@schmidma
Copy link
Member

I'd not like to merge this... As long as there is no justifiable reason...

@schluis
Copy link
Contributor Author

schluis commented Mar 12, 2025

Okay, how do you suggest to proceed?

@schluis schluis self-assigned this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@schluis schluis

Labels
cat:Vision GO25
Projects
Development
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

post-game task: Ball Recognition not working on bottom camera
2 participants
@schluis @schmidma