Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flags are absorbed from other projects when using Pepsi run (since Pepsi Max) #1651

Open
tuxbotix opened this issue Feb 25, 2025 · 0 comments
Labels
is:Bug This is a bug and should be prioritised.

Comments

@tuxbotix
Copy link
Contributor

tuxbotix commented Feb 25, 2025

I came across this while trying to run webots -> pepsi run --bin hulk_webots and got an error saying realtime scheduler cannot be set. This issue and changed command came after pepsi max.

Looking deeper, the root cause is that the features set for hulk_nao leaked into hulk_webots when calling pepsi run.

It is also the same behavious by cargo run --bin hulk_webots. It seems using cargo run in this way inspects the workspace file and reads feature flags used by everyone and use the combined result (unified?).
So I think the pepsi max PR isn't really at fault, rather how cargo run works?

Old pepsi run uses cargo run __manifest_path=... toml (I forgot the exact wording). This seems to read only the needed manifest, so features set for other executables aren't leaked into the build.

@tuxbotix tuxbotix added the is:Bug This is a bug and should be prioritised. label Feb 25, 2025
@tuxbotix tuxbotix moved this to Open in Development Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:Bug This is a bug and should be prioritised.
Projects
Status: Open
Development

No branches or pull requests

1 participant