Throw error in path deserialize Option<T> if its None

Author: ThagonDuarte

crates/control/src/behavior/node.rs

@@ -259,6 +259,7 @@ impl Behavior {
                         .filter_map(|(player_number, penalty)| {
                             penalty.is_none().then_some(player_number)
                         })
+                        // Skip the lowest non-penalized player number since this is always the Keeper or ReplacementKeeper
                         .skip(1)
                         .take(2);
                     if first_two_nonpenalized_nonkeeper_player_numbers

crates/path_serde/src/implementation.rs

@@ -103,7 +103,7 @@ where
 
 impl<T> PathDeserialize for Option<T>
 where
-    T: PathDeserialize + Default,
+    T: PathDeserialize,
 {
     fn deserialize_path<'de, D>(
         &mut self,
@@ -115,12 +115,9 @@ where
     {
         match self {
             Some(some) => some.deserialize_path(path, deserializer),
-            None => {
-                let mut value = T::default();
-                value.deserialize_path(path, deserializer)?;
-                *self = Some(value);
-                Ok(())
-            }
+            None => Err(deserialize::Error::PathDoesNotExist {
+                path: path.to_string(),
+            }),
         }
     }
 }

crates/spl_network_messages/src/game_controller_state_message.rs

@@ -315,7 +315,6 @@ impl GameState {
     Clone,
     Copy,
     Debug,
-    Default,
     Deserialize,
     Eq,
     PartialEq,
@@ -326,7 +325,6 @@ impl GameState {
 )]
 pub enum Team {
     Hulks,
-    #[default]
     Opponent,
 }