-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Burst and Burst Premium #8
base: main
Are you sure you want to change the base?
Conversation
split into free & premium, and moved it to the correct letter file (didn't notice that before!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide some example URLs of sites with both technologies for testing?
src/technologies/b.json
Outdated
"pricing": [ | ||
"free" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See here for the list of valid values. If everything that matches this detection is free then I think we can just remove pricing
all together, otherwise if Premium matches this too we should use freemium
.
Though to be fair HTTP Archive doesn't use these fields and it's more about conforming to the old (public) Wappalyzer convention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've dropped the pricing part. Currently it's set up to only match free, and pro has it's own entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example URLs:
https://complianz.io uses premium (burst-pro)
https://www.ikbeneenkameleon.nl/ uses the free version (burst-statistics)
@rlankhorst You can define versions using the tags feature. |
@rlankhorst please deduplicate the technology entries and add a few detection test sites. |
No description provided.