Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content and styling improvements #881

Merged
merged 19 commits into from
Aug 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/lighthouse/lighthouse-config-dev.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"service-worker": "off",
"speed-index": "off",
"splash-screen": "off",
"target-size": "off",
"themed-omnibox": "off",
"third-party-facades": "off",
"total-byte-weight": "off",
Expand Down
1 change: 1 addition & 0 deletions .github/lighthouse/lighthouse-config-prod.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"service-worker": "off",
"speed-index": "off",
"splash-screen": "off",
"target-size": "off",
"themed-omnibox": "off",
"third-party-facades": "off",
"total-byte-weight": "off",
Expand Down
55 changes: 47 additions & 8 deletions config/techreport.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,24 @@
},
"config": {
"default": {
"app": ["WordPress", "Squarespace", "Drupal"]
"app": ["WordPress", "Squarespace", "Drupal"],
"series": {
"breakdown": "client",
"breakdown_values": [
{
"name": "desktop",
"color": "#669E8E",
"color_dark": "#fff000",
"suffix": "%"
},
{
"name": "mobile",
"color": "#BD6EBE",
"color_dark": "#ff00f0",
"suffix": "%"
}
]
}
},
"popular_tech": {
"id": "popular_tech",
Expand Down Expand Up @@ -76,11 +93,13 @@
{
"name": "desktop",
"color": "#669E8E",
"color_dark": "#fff000",
"suffix": "%"
},
{
"name": "mobile",
"color": "#BD6EBE",
"color_dark": "#ff00f0",
"suffix": "%"
}
]
Expand Down Expand Up @@ -158,11 +177,13 @@
"values": [
{
"name": "desktop",
"color": "#669E8E"
"color": "#669E8E",
"color_dark": "#fff000"
},
{
"name": "mobile",
"color": "#BD6EBE"
"color": "#BD6EBE",
"color_dark": "#ff00f0"
}
],
"defaults": [
Expand Down Expand Up @@ -339,11 +360,13 @@
{
"name": "desktop",
"color": "#669E8E",
"color_dark": "#fff000",
"suffix": "%"
},
{
"name": "mobile",
"color": "#BD6EBE",
"color_dark": "#ff00f0",
"suffix": "%"
}
],
Expand Down Expand Up @@ -477,11 +500,13 @@
"values": [
{
"name": "desktop",
"color": "#669E8E"
"color": "#669E8E",
"color_dark": "#fff000"
},
{
"name": "mobile",
"color": "#BD6EBE"
"color": "#BD6EBE",
"color_dark": "#ff00f0"
}
],
"defaults": [
Expand Down Expand Up @@ -607,12 +632,14 @@
{
"name": "desktop",
"color": "#669E8E",
"suffix": " bytes"
"suffix": " bytes",
"color_dark": "#fff000"
},
{
"name": "mobile",
"color": "#BD6EBE",
"suffix": " bytes"
"suffix": " bytes",
"color_dark": "#ff00f0"
}
],
"defaults": [
Expand Down Expand Up @@ -669,8 +696,20 @@
"#8E3496",
"#CB377C"
],
"app_dark": [
"#5980EB",
"#D55316",
"#A8A9CA",
"#68A16D",
"#B979A7",
"#AC8D1C",
"#947786",
"#449DB1",
"#C861D2",
"#E24070"
],
"overrides": {
"WordPress": "#ff0000"
"WordPress": "#fff000"
}
},
"default": {
Expand Down
5 changes: 4 additions & 1 deletion src/js/components/drilldownHeader.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { DataUtils } from "../techreport/utils/data";

function setTitle(title) {
const mainTitle = document.querySelector('h2 span.main-title');
mainTitle.textContent = title;
Expand Down Expand Up @@ -33,7 +35,8 @@ function update(data, filters) {
const app = filters.app[0];

if(app) {
setTitle(app);
const formattedApp = DataUtils.formatAppName(app);
setTitle(formattedApp);
}

if(data[app]) {
Expand Down
2 changes: 1 addition & 1 deletion src/js/components/filters.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ class Filters {
const optionTmpl = document.getElementById('filter-option').content.cloneNode(true);
const option = optionTmpl.querySelector('option');
const formattedTech = technology.technology;
option.textContent = technology.technology;
option.textContent = DataUtils.formatAppName(technology.technology);
option.value = formattedTech;
if(formattedTech === techSelector.getAttribute('data-selected')) {
option.selected = true;
Expand Down
67 changes: 52 additions & 15 deletions src/js/techreport/index.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import Filters from '../components/filters';
import { Constants } from './utils/constants';
const { DrilldownHeader } = require("../components/drilldownHeader");
const { DataUtils } = require("./utils/data");
const { UIUtils } = require("./utils/ui");
Expand All @@ -25,17 +26,21 @@ class TechReport {
this.initializePage();
this.getAllMetricData();
this.bindSettingsListeners();
this.initializeAccessibility();
}

// Initialize the sections for the different pages
initializePage() {
this.updateStyling();

switch(this.pageId) {
case 'landing':
this.initializeLanding();
break;

case 'drilldown':
this.initializeReport();
this.getTechInfo();
break;

case 'comparison':
Expand All @@ -44,18 +49,14 @@ class TechReport {
}
}

// TODO
initializeLanding() {
}

// TODO
initializeReport() {
// TODO: Move to function
// Load accessibility/themeing info
initializeAccessibility() {
// Show indicators?
const showIndicators = localStorage.getItem('showIndicators');
document.querySelector('main').dataset.showIndicators = showIndicators;
document.querySelector('#indicators-check').checked = showIndicators === 'true';

// TODO: Move to function
// Dark or light mode?
const theme = localStorage.getItem('haTheme');
document.querySelector('html').dataset.theme = theme;
const btn = document.querySelector('.theme-switcher');
Expand All @@ -64,7 +65,13 @@ class TechReport {
} else if(theme === 'light') {
btn.innerHTML = '🌚 Switch to dark theme';
}
}

initializeLanding() {
}

// TODO
initializeReport() {
const sections = document.querySelectorAll('[data-type="section"]');
// TODO: add general config too
sections.forEach(section => {
Expand All @@ -79,7 +86,6 @@ class TechReport {
});

this.bindClientListener();
this.updateStyling();
}

// Watch for changes in the client dropdown
Expand Down Expand Up @@ -174,8 +180,6 @@ class TechReport {
},
];

const base = 'https://prod-gw-2vzgiib6.ue.gateway.dev/v1';

const technology = technologies.join('%2C')
.replaceAll(" ", "%20");

Expand All @@ -186,18 +190,21 @@ class TechReport {
technologies.forEach(tech => allResults[tech] = []);

Promise.all(apis.map(api => {
const url = `${base}/${api.endpoint}?technology=${technology}&geo=${geo}&rank=${rank}`;
const url = `${Constants.apiBase}/${api.endpoint}?technology=${technology}&geo=${geo}&rank=${rank}`;

return fetch(url)
.then(result => result.json())
.then(result => {
// Loop through all the rows of the API result
result.forEach(row => {
const parsedRow = {
...row,
}

// Parse the data and add it to the results
if(api.parse) {
parsedRow[api.metric] = api.parse(parsedRow[api.metric], parsedRow?.date);
const metric = parsedRow[api.metric] || parsedRow;
parsedRow[api.metric] = api.parse(metric, parsedRow?.date);
}

const resIndex = allResults[row.technology].findIndex(res => res.date === row.date);
Expand All @@ -217,6 +224,37 @@ class TechReport {
});
}

// Get the information about the selected technology
getTechInfo() {
const technologies = this.filters.app;
const technology = technologies.join('%2C')
.replaceAll(" ", "%20");

const url = `${Constants.apiBase}/technologies?technology=${technology}`;

fetch(url)
.then(result => result.json())
.then(result => {
const techInfo = result[0];

const categoryListEl = document.getElementsByClassName('category-list')[0];
categoryListEl.innerHTML = '';

const categories = techInfo && techInfo.category ? techInfo.category.split(', ') : [];
categories.forEach(category => {
const categoryItemEl = document.createElement('li');
categoryItemEl.className = 'cell';
categoryItemEl.textContent = category;
categoryListEl.append(categoryItemEl);
});

const descriptionEl = document.createElement('p');
descriptionEl.className = 'tech-description';
descriptionEl.textContent = techInfo?.description;
categoryListEl.after(descriptionEl);
});
}

// Update components and sections that are relevant to the current page
updateComponents(data) {
switch(this.pageId) {
Expand All @@ -239,12 +277,11 @@ class TechReport {
// Fetch the data for the filter dropdowns
getFilterInfo() {
const filterData = {};
const base = 'https://prod-gw-2vzgiib6.ue.gateway.dev/v1';

const filterApis = ['categories', 'technologies', 'ranks', 'geos'];

Promise.all(filterApis.map(api => {
const url = `${base}/${api}`;
const url = `${Constants.apiBase}/${api}`;

return fetch(url)
.then(result => result.json())
Expand Down
5 changes: 4 additions & 1 deletion src/js/techreport/tableLinked.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { DataUtils } from "./utils/data";

class TableLinked {
constructor(id, config, filters, data) {
this.id = id;
Expand Down Expand Up @@ -40,7 +42,8 @@ class TableLinked {
cell = document.createElement('th');
const link = document.createElement('a');
link.setAttribute('href', `?tech=${app}`);
link.innerHTML = app;
const formattedApp = DataUtils.formatAppName(app);
link.textContent = formattedApp;
cell.append(link);
} else if(column.key === 'client') {
cell = document.createElement('td');
Expand Down
Loading
Loading