Skip to content

🧪 test(dataform-service): add tests for runWorkflow and getCompilationResults#257

Draft
max-ostapenko wants to merge 1 commit intomainfrom
testing/dataform-service-runworkflow-3325976520998964703
Draft

🧪 test(dataform-service): add tests for runWorkflow and getCompilationResults#257
max-ostapenko wants to merge 1 commit intomainfrom
testing/dataform-service-runworkflow-3325976520998964703

Conversation

@max-ostapenko
Copy link
Contributor

🎯 What: The testing gap addressed was missing tests for runWorkflow inside infra/dataform-service/src/dataform.js.
📊 Coverage: Covered both runWorkflow and getCompilationResults to ensure DataformClient wrapper correctly passes the requested configs and extracts responses.
Result: Test coverage for dataform.js increased substantially by properly mocking Dataform APIs, reducing the risk of regressions on these core Dataform trigger functionalities.


PR created automatically by Jules for task 3325976520998964703 started by @max-ostapenko

Adds unit tests for `runWorkflow` and `getCompilationResults` in `infra/dataform-service/src/dataform.js`.
It uses `node:test` and mocks `DataformClient` from `@google-cloud/dataform` to verify the payload is sent as expected.
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant