解决导出 Modrinth 整合包因大文件导致的 Out Of Memory - #6631
Open
Hylfrd wants to merge 1 commit into
Open
Conversation
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6162
导出 Modrinth 整合包时，HMCL 会匹配远程资源并计算 MurmurHash2 指纹。原实现会将过滤后的完整文件存入
ByteArrayOutputStream，并在计算指纹前复制为新的字节数组，若文件过大会导致 OOM。此 PR 将 CurseForge MurmurHash2 指纹改为使用固定大小缓冲区计算，避免在内存中保存并复制过滤后的完整文件。第一遍读取用于统计过滤后的文件长度，第二遍按四字节分块计算指纹。