Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixed bugs] Refactor AddFaq page replace react-tag-input #970

Merged
merged 3 commits into from
May 27, 2024

Conversation

shivamgaur99
Copy link
Contributor

@shivamgaur99 shivamgaur99 commented May 26, 2024

Closes: #944

Here are the key changes:

Functional Components: I've refactored the class component into functional components to make the code more concise and readable.
Enhanced Tags Management: Implemented a more intuitive approach for adding and removing tags, enhancing the user experience.

Put an x in the boxes that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it pass all the current test cases.

Screenshots

image
image

Other information

Any other information that is important to this pull request?

@auto-assign auto-assign bot requested a review from Kajol-Kumari May 26, 2024 11:15
@shivamgaur99
Copy link
Contributor Author

@Kajol-Kumari Please review, i take reference from the addbrodcasts for tags input and also convert the class component to functional component.

And should we use the textarea tag for the answer input field? if any changes required, let me know

@shivamgaur99 shivamgaur99 changed the title [Fixed bugs] update AddFaq page replace react-tag-input [Fixed bugs] Refactor AddFaq page replace react-tag-input May 26, 2024
Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. the manage faq, is giving error, please fix it.
  2. The cursor should change to pointer, if i click on cross icon to remove the tag, check the image below -
Screenshot 2024-05-26 at 7 04 48 PM

ear
:frontend/src/pages/Admin/Components/Faq/AddFaq/AddFaq.jsx
@shivamgaur99
Copy link
Contributor Author

  1. the manage faq, is giving error, please fix it.
  2. The cursor should change to pointer, if i click on cross icon to remove the tag, check the image below -
Screenshot 2024-05-26 at 7 04 48 PM

changes done

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Kajol-Kumari Kajol-Kumari added level2 Bug fixing, adding small features. gssoc GSSoC'24 Label labels May 27, 2024
@Kajol-Kumari Kajol-Kumari merged commit 6bf031b into HITK-TECH-Community:main May 27, 2024
7 checks passed
@shivamgaur99 shivamgaur99 deleted the fix/issue-944 branch May 31, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level2 Bug fixing, adding small features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Add FAQ Page on Admin panel throwing Error
2 participants