Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring dashboard contact us component #951

Merged
merged 5 commits into from
May 25, 2024

Conversation

sarthu210
Copy link
Contributor

@sarthu210 sarthu210 commented May 22, 2024

Refactoring dashboard contact us component #875

Proposed changes

A mobile size problem occurred for the Contact Us card so used CSS VW width size parameter so it can auto fix its size

Brief description of what is fixed or changed

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshot

Before:

image

After:

image

Copy link

welcome bot commented May 22, 2024

Thank you and congrats🎉 for opening this pull request!💖

Please make sure you have followed our Contributing Guidelines.🙌 We will test out your code and reply in a bit with some pointers and requests.💿 There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄 If you haven't filled the template out, Please do so!🚀
Feel free to join our Slack Community.💖 We have different channels for active discussions.✨ Hope you have a great time there!😄

@auto-assign auto-assign bot requested a review from Kajol-Kumari May 22, 2024 17:10
Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-05-23 at 3 02 59 PM

For few screens, the card is appearing left aligned, can we make it centered aligned as well?

@sarthu210
Copy link
Contributor Author

Screenshot 2024-05-23 at 3 02 59 PM For few screens, the card is appearing left aligned, can we make it centered aligned as well?

sure I will make those changes by tomorrow night

@sarthu210
Copy link
Contributor Author

hello mam i resolve the issue by centering the items !

screenshot:
image

@Kajol-Kumari Kajol-Kumari added level1 Wiki or Major Documentation work. gssoc GSSoC'24 Label labels May 25, 2024
Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the left margin is a little more than right one but should be fine

@Kajol-Kumari Kajol-Kumari merged commit 06f3d47 into HITK-TECH-Community:main May 25, 2024
4 checks passed
Copy link

welcome bot commented May 25, 2024

Congrats on merging your first pull request! 🙌 🎉 ⚡️ Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step.😄🙌
Feel free to join our Slack Community.💖 We have different channels for active discussions.✨ Hope you have a great time there!😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level1 Wiki or Major Documentation work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants