Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAdmin api integrated with profile page issue#767 #902

Merged
merged 2 commits into from
May 17, 2024

Conversation

SwayamRana808
Copy link
Contributor

Issue that this pull request solves

Closes: #767

Proposed changes

getAdmin api integrated with profile page

Brief description of what is fixed or changed

getAdmin api integrated with profile page api

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface
Screenshot 2024-05-16 181259

Other information

Any other information that is important to this pull request

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-05-16 at 11 07 06 PM

If the value isn't present, let's not show undefine/null on the ui. Also, will the phone number appear on the ui if i added it later?

@SwayamRana808
Copy link
Contributor Author

yes phone no. will be shown .
i will hide undefined

@SwayamRana808
Copy link
Contributor Author

i have corrected null/undefined values
image

@Kajol-Kumari Kajol-Kumari added level2 Bug fixing, adding small features. gssoc GSSoC'24 Label labels May 17, 2024
@Kajol-Kumari Kajol-Kumari merged commit 349dcff into HITK-TECH-Community:main May 17, 2024
7 checks passed
@SwayamRana808 SwayamRana808 deleted the getAdmin branch May 31, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level2 Bug fixing, adding small features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Integrate The Profile Page of Admin With Backend
2 participants