Fixed: Every New Broadcast should be Broadcasted to Subscribers #1128
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| const [err, result] = await to(Broadcast.findOneAndUpdate({ _id : req.body.id }, { $set : data })); | ||
| const [err, result] = await to(Broadcast.findOneAndUpdate({ _id: req.body.id }, { $set: data })); |
Check failure
Code scanning / CodeQL
Database query built from user-controlled sources High
|
|
||
| const [err, result] = await to(Broadcast.findOneAndUpdate({ _id : req.body.id }, { $set : data })); | ||
| const [err, result] = await to(Broadcast.findOneAndUpdate({ _id: req.body.id }, { $set: data })); |
Check failure
Code scanning / CodeQL
Database query built from user-controlled sources High
| from: `HITK TECH Community <${config.EMAIL_USER}>`, | ||
| to: "[email protected]", | ||
| subject: `New Broadcast: ${data?.title} 😍`, | ||
| html: broadcastPublishMailTemplate(data), |
Check failure
Code scanning / CodeQL
Client-side cross-site scripting High
|
Hey @Kajol-Kumari Please review it and merge it. The PR failed due to some failures but those are no affect our functionality |
| @@ -703,7 +702,7 @@ a > span { | |||
| } | |||
| } | |||
|
|
|||
| @media screen and (max-width: 510px) { | |||
There was a problem hiding this comment.
this change shouldn't have come here, make sure to pull the latest master, rest looks fine
There was a problem hiding this comment.
Its okay, we are all learning 😊
Issue that this pull request solves
Closes: #1125
Proposed changes
As soon as a broadcast gets approved by the admins, it should broadcast it to all the email subscribers. This will help students to be updated with any new opportunities posted on the site.
Types of changes
Put an
xin the boxes that applyScreenshots
Other information
Any other information that is important to this pull request