Bug Fixed: The respective image should appear in the Recent&Previous Broadcast Cards #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kajol-Kumari please review in your free time |
Kajol-Kumari
requested changes
Jul 31, 2024
| backgroundBlendMode: "screen", | ||
| clipPath: "polygon(0 0, 100% 0, 100% 70%, 50% 100%, 0 70%)", | ||
| backgroundImage: `linear-gradient(45deg,rgba(255, 0, 90, 1) 0%,rgba(10, 24, 61, 1) 90%),url(${item.link})`, | ||
| // clipPath: "polygon(0 0, 100% 0, 100% 70%, 50% 100%, 0 70%)", |
| }; | ||
| return style; | ||
| }); | ||
|
|
||
| const cardImageArrayDark = dataa.map((item, i) => { | ||
| const style = { | ||
| height: "13em", | ||
| backgroundSize: "cover", | ||
| backgroundSize: "23.9em", | ||
| //backgroundSize: "cover", // Cover the entire area |
There was a problem hiding this comment.
remove all commented code and i would prefer the image to cover the whole space instead of fixed height
| backgroundBlendMode: "screen", | ||
| clipPath: "polygon(0 0, 100% 0, 100% 70%, 50% 100%, 0 70%)", | ||
| // clipPath: "polygon(0 0, 100% 0, 100% 70%, 50% 100%, 0 70%)", |
| @@ -62,23 +62,31 @@ export function Carousel(props) { | |||
| const cardImageArrayLight = dataa.map((item, i) => { | |||
| const style = { | |||
| height: "13em", | |||
| backgroundSize: "cover", | |||
| backgroundSize: "23.9em", | |||
| //backgroundSize: "cover", // Cover the entire area | |||
|
@Kajol-Kumari i am closing this pr will make another one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The respective image should appear in the Recent&Previous Broadcast Cards
Issue that this pull request solves
Closes: #1091
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply