[Issue #3694] Add Sorting To Saved Opportunity #3846
Conversation
… 3694/saved-opp-sorting
… 3694/saved-opp-sorting
…er-grants-gov into 3694/saved-opp-sorting
| elif order.sort_direction == SortDirection.DESCENDING: | ||
| order_col = desc(column) | ||
| if order.order_by == "close_date": | ||
| order_cols.append(order_col.nullslast()) |
There was a problem hiding this comment.
I think the type checking issues might be because of this confusing it.
I also think we want this to be nulls_last(order_col) based on: https://docs.sqlalchemy.org/en/20/core/sqlelement.html#sqlalchemy.sql.expression.nulls_last
… 3694/saved-opp-sorting
|
@doug-s-nava Similar to saved search list endpoint endpoint for the |
… 3694/saved-opp-sorting
|
@babebe got it. I guess we need a ticket to switch over our saved opportunities call? |
Yup, you're right |
… 3694/saved-opp-sorting
|
@babebe - this change looks good, but want to be careful about merging it if it immediately breaks a feature the frontend is building. Can we work with Aaron/Doug to make sure they get changes in that might be needed? |
Talked to Aaron. I will be merging the backend, then the front-end changes will be merged in. |
Summary
Fixes #{3694}
Time to review: 5 mins
Changes proposed
Updated route to POST endpoint to pass in pagination object
Added Input schema
UserSavedOpportunitiesRequestSchemawith pagination: can now sort with"created_at", "updated_at", "opportunity_title", "close_date"defaulting toagency_codeUpdated service func
get_saved_opportunitiesto implement the pagination and return also return pagination infoUpdated Test