[Issue #2643] Initial auth #3492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adds a context provider and hook to allow client components to access up to date logged in user information * adds a NextJS route to return user data decrypted from the session cookie passed up from the client * makes some temporary updates to the feature flags table in order for that page to act as a proof of concept for the functionality * moves some feature flags and loading spinner code to a more suitable location.
…em for client side use (#3374) * rewrites the FeatureFlagManager and useFeatureFlag hook to allow syncing flags between server and client using cookies * adds the `authOn` feature flag in frontend code and terraform * refactors the `environments` setup a bit to more easily expose feature flags * splits functionality that does not benefit from being held in the FeatureFlagsManager class into a helper file * moves feature flag manager file into a nested directory
## Summary Fixes #2962 ### Time to review: __15 mins__ ## Changes proposed * Adds a modal for the login link * Moves the env route handler to a redirect #### Mobile  #### Desktop  ### TODO - [x] verify it is accessible - [x] add tests - [x] look over again
* the callback route redirects to the home page on success, or an unauthorized page if no token is present or error page in error cases * creates error and unauthorized pages * adds middleware to implement the correct status codes on these redirects
acouch
requested review from
coilysiren,
mdragon,
andycochran,
btabaska,
doug-s-nava,
chouinar and
widal001
as code owners
|
does this need a review? is there new stuff in here, or has all of this already been reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2643
Time to review: 30 mins
Changes proposed