Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #2943] markup split typo bugfix #2942

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Issue #2943] markup split typo bugfix #2942

wants to merge 4 commits into from
+5 −4

Conversation

doug-s-nava
Copy link
Collaborator

@doug-s-nava doug-s-nava commented Nov 20, 2024 •
edited
Loading

Summary

Fixes #2943

Time to review: 10 mins

Changes proposed

Fixes a bug in the markup split logic that could result in markup containing quotation marks to not be properly evaluated

Context for reviewers

Test steps

  1. make db-seed on this branch
  2. visit the opportunity page for a seeded record containing markup in the description
  3. VALIDATE: description content is collapsed at the correct point and markup is not broken

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

@doug-s-nava doug-s-nava changed the title Ds/markup split typo bugfix [Issue #2943] markup split typo bugfix Nov 20, 2024
@doug-s-nava doug-s-nava marked this pull request as ready for review November 22, 2024 21:43
chouinar
chouinar approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@chouinar chouinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chouinar chouinar chouinar approved these changes

@mdragon mdragon Awaiting requested review from mdragon mdragon is a code owner

@andycochran andycochran Awaiting requested review from andycochran andycochran is a code owner

@acouch acouch Awaiting requested review from acouch acouch is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in markup parser evaluates quotes outside of tag parameters
2 participants
@doug-s-nava @chouinar