Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #2791] Create database table ExtractMetadata to store extract files #2880

Merged
merged 13 commits into from
Nov 18, 2024

Conversation

mikehgrantsgov
Copy link
Collaborator

Summary

Fixes #2791

Time to review: 10 mins

Changes proposed

  • Add a lookup table LkExtractType
  • Add a ExtractMetadata model and associated table for future use by the backend.

Context for reviewers

This issue unblocks many other backend tickets from creating and storing the necessary db extracts in S3.
See #2792, #2793, #2794

Additional information

See generated migration.

@mikehgrantsgov mikehgrantsgov marked this pull request as ready for review November 15, 2024 20:15
api/src/db/models/extract_models.py Outdated Show resolved Hide resolved
api/src/db/models/extract_models.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@chouinar chouinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mxk0 mxk0 removed request for mxk0 and widal001 November 18, 2024 00:22
@mikehgrantsgov mikehgrantsgov merged commit 04b68bf into main Nov 18, 2024
@mikehgrantsgov mikehgrantsgov deleted the mikehgrantsgov/2791-add-extracts-table branch November 18, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create database table ExtractMetadata to store extract files
4 participants