Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 2665] Implement db connection pools #2828

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

DavidDudas-Intuitial
Copy link
Collaborator

Summary

Maybe Fixes #2665

Time to review: 5 mins

Changes proposed

What was added, updated, or removed in this PR.

Added connection pools to /analytics, replacing single instance db connections. Implementation follows pattern in /api/src/adapters/db/clients/.

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers. Explain how the changes were verified.

This is latest step in a series of attempts to resolve failed db connections from /analytics step functions. See ticket history and comments for details.

Additional information

Screenshots, GIF demos, code examples or output to help show the changes working as expected.

coilysiren
coilysiren previously approved these changes Nov 13, 2024
Copy link
Collaborator

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@DavidDudas-Intuitial DavidDudas-Intuitial marked this pull request as ready for review November 13, 2024 08:50
@DavidDudas-Intuitial DavidDudas-Intuitial merged commit 2e5d6a8 into main Nov 13, 2024
10 checks passed
@DavidDudas-Intuitial DavidDudas-Intuitial deleted the issue-2665-connection-pool branch November 13, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Load GitHub data into Postgres
2 participants