[Issue 2665] Add temp logging to help troubleshoot db connection failures #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidDudas-Intuitial
requested review from
coilysiren,
widal001 and
acouch
as code owners
6 tasks
coilysiren
requested changes
Nov 12, 2024
| @@ -25,11 +25,15 @@ def get_db() -> Engine: | |||
| db = get_db_settings() | |||
| # inspired by simpler-grants-gov/blob/main/api/src/adapters/db/clients/postgres_client.py | |||
| token = db.password if db.local_env is True else generate_iam_auth_token(db) | |||
| url = f"postgresql+psycopg://{db.user}:{token}@{db.db_host}:{db.port}?sslmode={db.ssl_mode}" | |||
| print(f"TEMP DEBUG: db settings = {db}") | |||
| print(f"TEMP DEBUG: token = {token}") | |||
There was a problem hiding this comment.
Suggested change
| print(f"TEMP DEBUG: token = {token}") |
We can't have this in the logs, even if it's temporary
There was a problem hiding this comment.
@coilysiren ok, I removed it
coilysiren
previously approved these changes
Nov 12, 2024
coilysiren
approved these changes
Nov 13, 2024
DavidDudas-Intuitial
deleted the
issue-2665-troubleshoot-db-connection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially Fixes #2665
Time to review: 1 min
Changes proposed
Added
sslmodeto Postgres connection string. Also added some temporary logging to help troubleshoot db connection failures from analytics code. I will remove the logging in a future PR, as soon as I find the cause of the db connection failures.Context for reviewers
Analytics step functions have been deployed but when they execute their attempted connections to Postgres always fail.
Additional information