Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #2775] Opportunity number partial match fix #2777

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

chouinar
Copy link
Collaborator

@chouinar chouinar commented Nov 7, 2024

Summary

Fixes #2775

Time to review: 5 mins

Changes proposed

Adjusts the fields we query against and how in search

Context for reviewers

I wrote up a pretty thorough explanation of keyword vs non-keyword on #2775 - check that out. In short, the bug here is due to how the request/field being compared are tokenized. Keyword leaves a field "whole" and non-keyword tokenizes it into pieces. In the case of opportunity number splitting on each of the dashes (so ABC-123-XYZ becomes ["ABC", "123", "XYZ"]. In short, to support all the ways someone might want to query for an opportunity number, it's easiest to just include both.

Additional information

Some testing locally where I set the opportunity number to FY25-BSB-56789 and FY25-BSB-12345 for two opportunities:

Screenshot 2024-11-07 at 2 27 07 PM Screenshot 2024-11-07 at 2 27 12 PM Screenshot 2024-11-07 at 2 27 18 PM Screenshot 2024-11-07 at 2 27 31 PM

Copy link
Collaborator

@mdragon mdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, was hoping it would be that simple.

@chouinar chouinar merged commit 22ccd25 into main Nov 12, 2024
2 checks passed
@chouinar chouinar deleted the chouinar/2775-opp-number-search branch November 12, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search does not successfully partial match on opportunity number
2 participants