[Issue #2701] Remove FF code from components #2708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acouch
force-pushed
the
acouch/issue-2701-remove-ff-code-in-components
branch
from
5b4a0c2
to
fd6ef4d
Compare
mdragon
previously approved these changes
Nov 1, 2024
There was a problem hiding this comment.
This looks good. Just flagging I saw Doug had an older but still open PR that also touches the Nav stuff to avoid re-renders when Feature Flags are referenced from the Nav. That won't be an issue right now but might want to try to get those things brought together one way or the other.
acouch
force-pushed
the
acouch/issue-2701-remove-ff-code-in-components
branch
from
fd6ef4d
to
a2becf2
Compare
|
Closing this as we won't make this update in the next sprint, but can reopen in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2701
Time to review: 5 mins
The FF code wrapping individual components can be removed.