Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #2582] Ignore CVEs in upstream golang CLI #2606

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

coilysiren
Copy link
Collaborator

Summary

Relates to #2582

Time to review: 1 mins

Changes proposed

Ignores the CVE originally found in #2572

@@ -200,3 +200,4 @@ percent-complete:
sprint-reports: sprint-burndown percent-complete

sprint-reports-with-latest-data: gh-data-export sprint-reports

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-op diff on the analytics package to test

@coilysiren coilysiren marked this pull request as draft October 28, 2024 16:32
@coilysiren coilysiren changed the title Ignore CVE in upstream golang CLI [Issue #2582] Ignore CVE in upstream golang CLI Oct 28, 2024
@coilysiren coilysiren changed the title [Issue #2582] Ignore CVE in upstream golang CLI [Issue #2582] Ignore CVEs in upstream golang CLI Oct 28, 2024
@coilysiren coilysiren marked this pull request as ready for review October 28, 2024 16:47
Copy link
Collaborator

@widal001 widal001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for silencing these alerts that will be addressed once we complete #2590 and move away from using the gh CLI

@coilysiren coilysiren merged commit ff57a80 into main Oct 28, 2024
22 checks passed
@coilysiren coilysiren deleted the kai/analytics-vuln-ignore branch October 28, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants