Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call GitHub graphql API directly from python #2590

Open
3 tasks
widal001 opened this issue Oct 25, 2024 · 1 comment · May be fixed by #3393
Open
3 tasks

Call GitHub graphql API directly from python #2590

widal001 opened this issue Oct 25, 2024 · 1 comment · May be fixed by #3393
Assignees

Comments

@widal001
Copy link
Collaborator

Summary

Update the analytics.integrations.github sub-package to call the GitHub GraphQL API directly from python instead of using the gh CLI as an intermediary.

Motivation

  • The gh CLI uses a pinned version of go that has a CVE
  • Simplifies the Dockerfile
  • Removes a somewhat clunky sub-process call
  • Enables us to add better error handling for GitHub API responses
  • Enables us to mock the GitHub API for tests

Acceptance criteria

  • The analytics.integrations.github sub-package calls the GitHub GraphQL API without using the gh CLI
  • The make-graphql-query.sh has been replaced with a conceptually similar python function or method
  • The gh CLI tool and jq are removed from the analytics/Dockerfile
@widal001 widal001 self-assigned this Oct 25, 2024
@widal001 widal001 changed the title [Analytics] Call GitHub graphql API directly from python Call GitHub graphql API directly from python Oct 30, 2024
@widal001
Copy link
Collaborator Author

widal001 commented Nov 4, 2024

Bumping this to sprint 1.4 since I won't have a chance to work on this until I'm back in office and it's not blocking anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant