chore: update ZAP DAST scan to ignore warning and below #3259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnalley
changed the title
jonnalley
requested review from
johndeange,
rajohnson90,
fpigeonjr,
maiyerlee,
Santi-3rd and
weimiao67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Further modified the command line options to the ZAP docker container to further attempt to silence warning-level and below threshold of findings. This is believed to be the intent of the current config but it has been still producing an undesirable level/quality of findings.
This is a pre-cursor to a future PR that will change this action over to testing the production environment instead of the staging environment.
Issue
N/A
How to test
Manually run or wait for scheduled run of this GHA and see if warning-level issues and below are produced.
Links
https://www.zaproxy.org/docs/docker/full-scan/
https://github.com/marketplace/actions/zap-full-scan