feat: add CAN detail form #3186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove before merging in to main
captured in the demo
Co-authored-by: Santi-3rd <[email protected]>
test: can edit form e2e tests
fpigeonjr
commented
Dec 11, 2024
fpigeonjr
requested review from
maiyerlee,
johndeange,
jonnalley,
rajohnson90,
devops-chris and
Santi-3rd
maiyerlee
approved these changes
Dec 11, 2024
maiyerlee
approved these changes
Dec 11, 2024
Santi-3rd
approved these changes
Dec 11, 2024
rajohnson90
reviewed
Dec 11, 2024
|
|
||
| let res = suite.get(); | ||
|
|
||
| const cn = classnames(suite.get(), { |
There was a problem hiding this comment.
I'm assuming cn stands for className or classNames? If it's not too much effort, could we potentially try to not have super short variable names in favor of readability?
There was a problem hiding this comment.
Great idea! This naming convention is used in other FE components for form validation. Would it be okay to track it in a new tech debt ticket?
There was a problem hiding this comment.
I created this story to track the rename: #3210
rajohnson90
approved these changes
Dec 11, 2024
johndeange
approved these changes
Dec 11, 2024
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Issue
#310 #3098
How to test
Screenshots
If relevant, e.g. for a front-end feature
Definition of Done Checklist