feat: api integration is updating CAN List cards #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiyerlee
merged commit 35bba25
into
OPS-2962-update-CAN-summary-endpoint
2 checks passed
maiyerlee
added a commit
that referenced
this pull request
Dec 2, 2024
* feat: add many cans and filter support to can budget summary endpoint * feat: update new_funding calc, refactor for all cans, fix FE endpoint usage * feat: use funding details to get new funding w/o given FY * feat: handle new funding for multiyear cans * fix: remove extra ? * fix: use correct symbol in query param chaining * chore: integrate can-funding-summary endpoint (#3112) * feat: add fy as filter option, fix fe url (#3113) * fix: ops api url for funding sums * refactor: be logic * feat: apply fy to filter * refactor: rename view for consistency * chore: add Marshmallow schema * chore: renaming, update can schema to basic * feat: pass funding totals to summary card * chore: calc total spending * fix: correct id param and endpoint response usage * chore: remove commented out code * feat: api integration is updating CAN List cards (#3125) * feat: api integration is updating CAN List cards * chore: cleanup * test: fix BE unit tests * chore: refactor and fix portfolio filter FE unit test * test: remove unused fixtures * chore: add docstrings to can utils * feat: add can funding total request schema and service --------- Co-authored-by: Guillermo Santiago III <[email protected]> Co-authored-by: Frank Pigeon Jr. <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mob work from the week of 11/22/24