Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3052: Add additional agreement attributes to /cans/ response #3092 #3108

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

3052: Add additional agreement attributes to /cans/ response #3092 #3108

wants to merge 3 commits into from

Conversation

maiyerlee
Copy link
Contributor

@maiyerlee maiyerlee commented Nov 20, 2024 •
edited
Loading

What changed

Include the following fields in the BudgetLineItem response object returned by the /cans/ endpoint:

  • agreement_name
  • agreement_type
  • awarding_entity_id (Agreement Procurement Shop Code)

Issue

#3052

How to test

Unit tests passing.

Screenshots

N/A

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

Links

N/A

@maiyerlee maiyerlee self-assigned this Nov 20, 2024
@maiyerlee maiyerlee marked this pull request as ready for review November 20, 2024 19:36
fpigeonjr
fpigeonjr reviewed Nov 21, 2024
View reviewed changes
backend/openapi.yml
agreement:
type: object
$ref: "#/components/schemas/SimpleAgreementSchema"
SimpleAgreementSchema:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧡 let's update the CANTypes.d.ts to match

Santi-3rd
Santi-3rd approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Santi-3rd Santi-3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the unit tests passed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpigeonjr fpigeonjr fpigeonjr approved these changes

@Santi-3rd Santi-3rd Santi-3rd approved these changes

@rajohnson90 rajohnson90 Awaiting requested review from rajohnson90

@johndeange johndeange Awaiting requested review from johndeange

Assignees

@maiyerlee maiyerlee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maiyerlee @fpigeonjr @Santi-3rd