Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several issues with panel distortion #1808

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Fix several issues with panel distortion #1808

merged 1 commit into from
Mar 17, 2025

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Mar 17, 2025

This fixes a number of issues with panel distortion, including the following:

  1. Distortion functions could not be selected in the instrument form view
  2. The overlays would not update properly when distortion parameters would change
  3. Overlays in the Cartesian view were never distortion-corrected
  4. Powder overlays were only correctly distorted in the raw view

All of these issues are now fixed.

Depends on: HEXRD/hexrd#784

Fixes: #1807

This fixes a number of issues with panel distortion, including the following:

1. Distortion functions could not be selected in the instrument form view
2. The overlays would not update properly when distortion parameters would change
3. Overlays in the Cartesian view were never distortion-corrected
4. Powder overlays were only correctly distorted in the raw view

All of these issues are now fixed.

Signed-off-by: Patrick Avery <[email protected]>
@psavery psavery merged commit 385cb5d into master Mar 17, 2025
9 checks passed
@psavery psavery deleted the fix-distortion branch March 17, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drop-down menu for adding detector distortion unresponsive
2 participants