Fix several issues with panel distortion #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a number of issues with panel distortion, including the following: 1. Distortion functions could not be selected in the instrument form view 2. The overlays would not update properly when distortion parameters would change 3. Overlays in the Cartesian view were never distortion-corrected 4. Powder overlays were only correctly distorted in the raw view All of these issues are now fixed. Signed-off-by: Patrick Avery <[email protected]>
bnmajor
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of issues with panel distortion, including the following:
All of these issues are now fixed.
Depends on: HEXRD/hexrd#784
Fixes: #1807