Add missing test files to h5copygentest #5482
Conversation
mattjala
added
Priority - 2. Medium ⏹
mattjala
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09 and
brtnfld
as code owners
brtnfld
removed
the
Type - Bug / Bugfix
| dataspace_id = H5Screate_simple(2, dims, NULL); | ||
| datatype_id = H5Tcopy(H5T_NATIVE_INT32); | ||
| dataset_id = | ||
| H5Dcreate2(file_id, "dynlibud", datatype_id, dataspace_id, H5P_DEFAULT, H5P_DEFAULT, H5P_DEFAULT); |
There was a problem hiding this comment.
This won't create quite the same file. A user-defined filter with the ID 300 and comment "dynlibud" (which I think is just the name that h5dump is interpreting) needs to be added to the dataset. If you can track down the original code that created the files (if it exists), that would be better.
There was a problem hiding this comment.
(That also means the dataset will need to be chunked 10x5 according to h5dump)
There was a problem hiding this comment.
Looks like the filter is from https://github.com/HDFGroup/hdf5/blob/develop/tools/test/h5dump/dynlib_dump.c and the file is from https://github.com/HDFGroup/hdf5/blob/develop/tools/test/h5dump/h5dumpgentest.c#L113 / https://github.com/HDFGroup/hdf5/blob/develop/tools/test/h5dump/h5dumpgentest.c#L11196. Probably best again not to duplicate the code, but at least we have the original.
Generate
tudfilter.h5andtudfilter2.h5through h5copygentest, to match the checking in h5copy testfiles