Skip to content

Refactor: improve variable usage in hasp_attribute_helper.h #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
oradke wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor: improve variable usage in hasp_attribute_helper.h #949

oradke wants to merge 1 commit into from

Conversation

@oradke
Copy link

@oradke oradke commented Sep 20, 2025 •
edited
Loading

Fixes #947 (comment)

  • Variables such as %ip% and %hostname% are now properly handled anywhere in the text
  • multiple variables can be used, even repeatedly
  • variable handling can be escaped by using \ (e.g. "\%ip%" returns "%ip%")

@oradke oradke mentioned this pull request Sep 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using variables fails when text property contains more than just the variable

1 participant

@oradke