Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Python stubs consistently #1662

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Conversation

dgelessus
Copy link
Contributor

Preparation for #1661 to make the diff more readable. This sorts all definitions in the Python stubs consistently, according to the established sorting style in the stubs:

  • By default, all definitions are sorted in case-sensitive alphabetical order.
  • Enum constants are sorted by their numeric value.
  • In classes, all attributes/properties are placed before all methods.

This PR only fixes the sorting and contains no other fixes or style changes.

Except where class inheritance requires a different order.
And then in alphabetical order, if two enum constants have the same
numeric value.
@dpogue
Copy link
Member

dpogue commented Feb 20, 2025

Is there remaining work to be done on this PR, or is it ready for review? I know it's holding up the other one

@dgelessus dgelessus marked this pull request as ready for review February 20, 2025 08:53
@dgelessus
Copy link
Contributor Author

This PR is ready - looks like I accidentally submitted it as a draft, oops. Thanks for the reminder!

@Hoikas Hoikas merged commit 0bdeea6 into H-uru:master Feb 21, 2025
18 checks passed
@dgelessus dgelessus deleted the sort_python_stubs branch February 21, 2025 20:19
Hoikas added a commit to Hoikas/Plasma that referenced this pull request Mar 4, 2025

Verified

This commit was signed with the committer’s verified signature.
Hoikas Adam Johnson
Don't deadlock a material window picker hack worker thread.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants