Skip to content

Prevent sending smaller limit value to the datasource for the last page #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent sending smaller limit value to the datasource for the last page #147

wants to merge 1 commit into from

Conversation

yuppyavd
Copy link

Reduced limit for the last page should be only passed to table.setVisibleRange method, not for dataSource.load(...).

@BenDol
Copy link
Contributor

BenDol commented Mar 28, 2018

Can you create this PR against the release_2.1 branch? Then I can merge this in for the next release. Thanks for the contribution!

@yuppyavd
Copy link
Author

Code in release_2.1 branch is little different and it should works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuppyavd @BenDol