Fixed bug that wasn't sending the instance to the confirmation messag…

…e function
Gustavinho · Jun 24, 2021 · ad7fb7c · ad7fb7c
1 parent 5889441
commit ad7fb7c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/Actions/Action.php b/src/Actions/Action.php
@@ -69,10 +69,6 @@ private function setMessage($type = 'success', $message = null)
 
     public function shouldBeConfirmed()
     {
-        if (method_exists($this, 'getConfirmationMessage')) {
-            return !empty($this->getConfirmationMessage(null));
-        }
-
-        return false;
+        return method_exists($this, 'getConfirmationMessage');
     }
 }
diff --git a/tests/Feature/ExecuteActionsTest.php b/tests/Feature/ExecuteActionsTest.php
@@ -64,6 +64,8 @@ public function testSeeConfirmationMessage()
             ]);
     }
 
+    // TODO: test custom confirmation message
+
     public function testCallActionAfterConfirmationMessage()
     {
         $user = factory(UserTest::class)->create();