Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin bmlab version to last version compatible #56

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Sep 21, 2022

This pins bmlab to the last version compatible with the current status of Impose (bmlab >= 0.6.0 had file format changes) and fixes the check pipeline which got broken with an Ubuntu update probably. Necessary for #54.

@raimund-schluessler
Copy link
Contributor Author

@paulmueller There seems to be something generally broken here. Even when just pinning bmlab to the version that worked with the last release, the pipeline fails.

@raimund-schluessler raimund-schluessler changed the title Pin bmlab version to last version known working Pin bmlab version to last version compatible Sep 21, 2022
@raimund-schluessler
Copy link
Contributor Author

I figured it out. An update of Ubuntu probably broke the release pipeline. This PR fixes it now.

@raimund-schluessler raimund-schluessler added the bug Something isn't working label Sep 21, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #56 (5393230) into main (ec7ea53) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   76.69%   76.69%           
=======================================
  Files          35       35           
  Lines        2515     2515           
=======================================
  Hits         1929     1929           
  Misses        586      586           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raimund-schluessler raimund-schluessler marked this pull request as ready for review September 21, 2022 10:56
@raimund-schluessler raimund-schluessler merged commit c62664b into main Sep 21, 2022
@raimund-schluessler raimund-schluessler deleted the fix/noid/pin-bmlab-version branch September 21, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants