forked from svenvc/NeoJSON
-
Notifications
You must be signed in to change notification settings - Fork 3
NeoJson update #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tukanos
wants to merge
99
commits into
GsDevKit:gs_master
Choose a base branch
from
tukanos:NeoJSONUpdate
base: gs_master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed bogus formatted .properties file
…ings (as per the standard) Add a unit test, refactor #encodeKey: messages a bit
Add NeoJSONFloatPrinter as a first custom implementation with fixed parameters (for now) Add NeoJSONFloatPrinterTests Add NeoJSONWriterTests>>#testFloatPrinter
Add #lowPrecision and #scientificOnly as examples with unit tests.
This is meant as a convenience feature only as the official JSON specification clearly states "An object is an unordered set of name/value pairs".
…o 7 & 8, but fixed in Pharo 9 and later) by adding the correct implementation to NeoJSONObject
Add Pharo 10 to CI
- Checking if SmallTime class is available, if yes use it, if no stick to the standard one - Making the test work with 24-hour or 12-hour format
In Pharo IdentityDictionary is a subclass of Dictionary, but in GemStone it is a KeyValueDictionary. Need to create method to get correct results.
In Pharo String is a subclass of Arraycollection, but in GemStone it is CharacterCollection. In case MultiByteString is used we need to have neoJsonOn: for those too.
To quote RFC8259, which defines JSON format: An object is an *unordered* collection of zero or more name/value pairs, where a name is a string and a value is a string, number, boolean, null, object, or array.
@tukanos, I've been under the weather for the last couple of weeks (sleep issues), so I've just run the PR job |
@dalehenrich Sorry to hear that. I hope it gets eventually better. Take care of yourself! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the library.