Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add serviceaccount creation for greptimedb-cluster #91

Merged
merged 5 commits into from
Dec 27, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Dec 10, 2023

No description provided.

@daviderli614
Copy link
Member

note: The GreptimeDBCluster spec.base.main not have serviceAccountName field.

@zyy17
Copy link
Collaborator Author

zyy17 commented Dec 15, 2023

note: The GreptimeDBCluster spec.base.main not have serviceAccountName field.

Maybe you're wrong. I add the serviceAccountName in .base, not .base.main.

@zyy17 zyy17 force-pushed the refactor/add-sa-for-cluster branch from 2bbade5 to 439e928 Compare December 22, 2023 07:53
@zyy17 zyy17 force-pushed the refactor/add-sa-for-cluster branch from 439e928 to b27299f Compare December 22, 2023 08:40
@zyy17 zyy17 force-pushed the refactor/add-sa-for-cluster branch from b27299f to 44432b2 Compare December 22, 2023 08:41
@zyy17 zyy17 force-pushed the refactor/add-sa-for-cluster branch from fb637d2 to 7839cc3 Compare December 27, 2023 06:18
Copy link
Member

@daviderli614 daviderli614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyy17 zyy17 merged commit aae6ff1 into GreptimeTeam:main Dec 27, 2023
2 checks passed
@zyy17 zyy17 deleted the refactor/add-sa-for-cluster branch December 27, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants