Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use b64enc function when create secrets of s3 credentials and use range statement to create secret data #51

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Jul 7, 2023

No description provided.

…nd use range statement to create secret data
@zyy17 zyy17 force-pushed the refactor/modify-s3-secrets-cretion branch from f238c09 to 77411ca Compare July 7, 2023 08:31
@zyy17 zyy17 assigned daviderli614 and unassigned daviderli614 Jul 7, 2023
@zyy17 zyy17 requested a review from daviderli614 July 7, 2023 08:49
Copy link
Member

@daviderli614 daviderli614 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyy17 zyy17 merged commit 342ecd0 into GreptimeTeam:main Jul 7, 2023
2 checks passed
@zyy17 zyy17 deleted the refactor/modify-s3-secrets-cretion branch July 7, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants