Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump greptimedb version from v0.9.3 to v0.9.4 #168

Merged

Conversation

daviderli614
Copy link
Member

@daviderli614 daviderli614 commented Oct 16, 2024

Summary by CodeRabbit

  • New Features

    • Updated versioning for both greptimedb-cluster and greptimedb-standalone Helm charts to version 0.2.15 and 0.1.23, respectively.
    • Updated application version to 0.9.4 across both charts.
    • Updated image tags to v0.9.4 for the main GreptimeDB image in both clusters.
  • Documentation

    • Revised README files to reflect new version numbers and image tags.

Copy link

coderabbitai bot commented Oct 16, 2024

Walkthrough

The pull request includes updates to the Helm charts for both the greptimedb-cluster and greptimedb-standalone. Specifically, the version numbers in the Chart.yaml files have been incremented, and the application version has been updated across the relevant files. Additionally, the image tags in the README.md and values.yaml files have been changed to reflect the new application version. Overall, these changes ensure that the Helm charts are aligned with the latest versioning of the application.

Changes

File Path Change Summary
charts/greptimedb-cluster/Chart.yaml Updated version from 0.2.14 to 0.2.15, appVersion from 0.9.3 to 0.9.4.
charts/greptimedb-cluster/README.md Updated Version from 0.2.14 to 0.2.15, AppVersion from 0.9.3 to 0.9.4, image tag to v0.9.4.
charts/greptimedb-cluster/values.yaml Updated image tag from v0.9.3 to v0.9.4.
charts/greptimedb-standalone/Chart.yaml Updated version from 0.1.22 to 0.1.23, appVersion from 0.9.3 to 0.9.4.
charts/greptimedb-standalone/README.md Updated Version from 0.1.22 to 0.1.23, AppVersion from 0.9.3 to 0.9.4, image tag to v0.9.4.
charts/greptimedb-standalone/values.yaml Updated image tag from v0.9.3 to v0.9.4.

Possibly related PRs

Suggested reviewers

  • zyy17

Poem

🐰 In the meadow, changes bloom,
New versions rise, dispelling gloom.
From 0.2.14 to 0.2.15,
A hop, a skip, a leap, so keen!
With tags anew, we dance and play,
GreptimeDB shines bright today! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 7828914 and e9b24b9.

📒 Files selected for processing (6)
  • charts/greptimedb-cluster/Chart.yaml (1 hunks)
  • charts/greptimedb-cluster/README.md (2 hunks)
  • charts/greptimedb-cluster/values.yaml (1 hunks)
  • charts/greptimedb-standalone/Chart.yaml (1 hunks)
  • charts/greptimedb-standalone/README.md (2 hunks)
  • charts/greptimedb-standalone/values.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • charts/greptimedb-cluster/Chart.yaml
  • charts/greptimedb-standalone/Chart.yaml
🧰 Additional context used
🔇 Additional comments (10)
charts/greptimedb-standalone/values.yaml (1)

7-7: LGTM! Verify latest stable version.

The update of the GreptimeDB image tag from v0.9.3 to v0.9.4 is correct and aligns with the PR objectives.

To ensure we're using the latest stable version, let's verify the available tags for the GreptimeDB image:

✅ Verification successful

Confirmed: GreptimeDB image tag v0.9.4 is available on Docker Hub.

The update to charts/greptimedb-standalone/values.yaml is approved.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the latest stable version of GreptimeDB

# Fetch the latest 5 version tags from Docker Hub
echo "Latest 5 version tags for greptime/greptimedb:"
curl -s https://hub.docker.com/v2/repositories/greptime/greptimedb/tags?page_size=5&ordering=last_updated | jq -r '.results[].name' | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+$'

# Check if v0.9.4 is among the latest tags
if curl -s https://hub.docker.com/v2/repositories/greptime/greptimedb/tags?page_size=100 | jq -r '.results[].name' | grep -q '^v0.9.4$'; then
    echo "v0.9.4 is available on Docker Hub."
else
    echo "Warning: v0.9.4 was not found among the latest 100 tags on Docker Hub."
fi

Length of output: 9321

charts/greptimedb-standalone/README.md (4)

5-5: LGTM: Version badge update

The Version badge has been correctly updated from 0.1.22 to 0.1.23, which is consistent with the PR objective of bumping the version. This change follows semantic versioning principles for a patch version increment.


5-5: LGTM: AppVersion badge update

The AppVersion badge has been correctly updated from 0.9.3 to 0.9.4, which aligns with the PR objective of bumping the greptimedb version. This change follows semantic versioning principles for a patch version increment.


Line range hint 1-100: Overall review: LGTM

All changes in this file are consistent with the PR objective of bumping the greptimedb version from v0.9.3 to v0.9.4. The updates to the Version badge, AppVersion badge, and image tag in the values table have been correctly implemented. These changes ensure that the README.md file accurately reflects the new version information for the greptimedb-standalone Helm chart.

To maintain consistency, please ensure that all other relevant files in the repository have been updated with the new version number.

🧰 Tools
🪛 Markdownlint

8-8: null
Bare URL used

(MD034, no-bare-urls)


67-67: LGTM: Image tag update

The image.tag value has been correctly updated from "v0.9.3" to "v0.9.4", which is consistent with the PR objective of bumping the greptimedb version. This update ensures that the default image tag in the values section matches the new application version.

To ensure consistency across all files, please run the following script to verify that all references to the version have been updated:

✅ Verification successful

Verification Successful: Image Tag Fully Updated

All instances of v0.9.3 have been removed, and v0.9.4 is correctly updated across the repository in both values.yaml and README.md files for greptimedb-cluster and greptimedb-standalone.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all occurrences of the old and new versions in the repository

echo "Checking for any remaining occurrences of v0.9.3:"
rg --type yaml --type md "v0.9.3"

echo "Verifying all occurrences of the new version v0.9.4:"
rg --type yaml --type md "v0.9.4"

Length of output: 581

charts/greptimedb-cluster/values.yaml (1)

7-7: LGTM: Version bump looks good.

The update of the GreptimeDB image tag from v0.9.3 to v0.9.4 is straightforward and appears to be the only change in this file. This type of change is typical for maintenance updates and doesn't introduce new features or alter existing behaviors.

Let's verify if this version bump is consistent across all relevant files in the PR:

charts/greptimedb-cluster/README.md (4)

5-5: Version badge correctly updated

The version badge has been properly updated from 0.2.14 to 0.2.15, which is consistent with the PR objective of bumping the version.


5-5: AppVersion badge correctly updated

The AppVersion badge has been appropriately updated from 0.9.3 to 0.9.4, reflecting the new version of GreptimeDB as per the PR objective.


5-5: README updates are consistent and complete

All version-related changes in the README have been properly updated:

  1. Chart version incremented to 0.2.15
  2. AppVersion updated to 0.9.4
  3. Image tag updated to v0.9.4

These changes are consistent with the PR objective of bumping the GreptimeDB version from v0.9.3 to v0.9.4.

Also applies to: 178-178


178-178: Image tag correctly updated

The image tag has been properly updated from v0.9.3 to v0.9.4, which is consistent with the AppVersion update and PR objective.

Please run the following script to verify the availability of the new image:

✅ Verification successful

Image availability verification needed

The previous verification attempt failed because the docker command is not available. Please run the following script to verify the availability of the new GreptimeDB image using the Docker Hub API:


Image tag correctly updated and verified

The image tag has been properly updated from v0.9.3 to v0.9.4, and the availability of the new image has been confirmed.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the availability of the new GreptimeDB image

# Test: Check if the new image tag exists
docker pull docker.io/greptime/greptimedb:v0.9.4
if [ $? -eq 0 ]; then
    echo "Image docker.io/greptime/greptimedb:v0.9.4 is available"
else
    echo "Error: Image docker.io/greptime/greptimedb:v0.9.4 is not available"
    exit 1
fi

Length of output: 296


Script:

#!/bin/bash
# Description: Verify the availability of the new GreptimeDB image using Docker Hub API

IMAGE_NAME="greptime/greptimedb"
TAG="v0.9.4"
URL="https://registry.hub.docker.com/v2/repositories/${IMAGE_NAME}/tags/${TAG}/"

# Use curl to check if the tag exists
HTTP_STATUS=$(curl -s -o /dev/null -w "%{http_code}" "$URL")

if [ "$HTTP_STATUS" -eq 200 ]; then
    echo "Image docker.io/${IMAGE_NAME}:${TAG} is available"
    exit 0
elif [ "$HTTP_STATUS" -eq 404 ]; then
    echo "Error: Image docker.io/${IMAGE_NAME}:${TAG} is not available"
    exit 1
else
    echo "Error: Unable to determine the availability of docker.io/${IMAGE_NAME}:${TAG} (HTTP status: $HTTP_STATUS)"
    exit 1
fi

Length of output: 425


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@discord9 discord9 merged commit 5026848 into GreptimeTeam:main Oct 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants