Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to set all the arguments of greptime helm chart #99

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Jul 19, 2023

related to #91

pkg/cmd/gtctl/cluster/create/create.go Outdated Show resolved Hide resolved
pkg/helm/helm.go Show resolved Hide resolved
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyy17
Copy link
Collaborator

zyy17 commented Jul 31, 2023

@daviderli614 PTAL

@zyy17 zyy17 merged commit 2182876 into GreptimeTeam:develop Aug 1, 2023
4 checks passed
@shawnh2 shawnh2 deleted the feat/add-set-cmd branch August 1, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants