Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new command gtctl connect mysql #86

Merged
merged 13 commits into from
Jul 31, 2023

Conversation

sjcsjc123
Copy link
Contributor

image
The password is empty, just press enter and start mysql cli.

Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

pkg/cmd/gtctl/connect/mysql/mysql.go Outdated Show resolved Hide resolved
pkg/cmd/gtctl/connect/connect.go Outdated Show resolved Hide resolved
pkg/cmd/gtctl/connect/mysql/mysql.go Outdated Show resolved Hide resolved
pkg/cmd/gtctl/connect/mysql/mysql.go Outdated Show resolved Hide resolved
@sjcsjc123 sjcsjc123 marked this pull request as draft July 18, 2023 16:49
@sjcsjc123
Copy link
Contributor Author

@zyy17 mysql has been down. If ok, i will add pg.

@zyy17
Copy link
Collaborator

zyy17 commented Jul 25, 2023

@sjcsjc123 You can change the PR status as ready for review.

@sjcsjc123 sjcsjc123 marked this pull request as ready for review July 25, 2023 05:46
pkg/cmd/gtctl/cluster/connect/connect.go Show resolved Hide resolved
pkg/cmd/gtctl/cluster/connect/connect.go Outdated Show resolved Hide resolved
pkg/cmd/gtctl/cluster/connect/connect.go Outdated Show resolved Hide resolved
pkg/cmd/gtctl/cluster/connect/connect.go Outdated Show resolved Hide resolved
pkg/cmd/gtctl/cluster/connect/mysql/mysql.go Outdated Show resolved Hide resolved
pkg/cmd/gtctl/cluster/connect/mysql/mysql.go Outdated Show resolved Hide resolved
pkg/cmd/gtctl/cluster/connect/mysql/mysql.go Outdated Show resolved Hide resolved
pkg/cmd/gtctl/cluster/connect/mysql/mysql.go Outdated Show resolved Hide resolved
pkg/cmd/gtctl/cluster/connect/mysql/mysql.go Show resolved Hide resolved
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sjcsjc123 I feel very excited to merge it! Thank you for your job!

@zyy17 zyy17 merged commit 27d2f7c into GreptimeTeam:develop Jul 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants