Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid pushing invalid addr args #195

Merged
merged 3 commits into from
Mar 14, 2024
Merged

fix: avoid pushing invalid addr args #195

merged 3 commits into from
Mar 14, 2024

Conversation

waynexia
Copy link
Member

closes #194

The generated command now becomes

 run 'frontend.0' binary '../target/greptimedb-dev/release/greptime' with args: '[--log-level=info frontend start --metasrv-addr=127.0.0.1:3002 -c=../config/frontend.example.toml]', log: '~/.gtctl/mycluster/logs/frontend.0'

without invalid args

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.76%. Comparing base (7861241) to head (cc591fa).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #195   +/-   ##
========================================
  Coverage    37.76%   37.76%           
========================================
  Files           16       16           
  Lines         1300     1300           
========================================
  Hits           491      491           
  Misses         704      704           
  Partials       105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps also for generateMetaSrvAddr and generateDatanodeAddr

pkg/components/frontend.go Outdated Show resolved Hide resolved
@waynexia
Copy link
Member Author

The e2e test failure seems unrelated to this change. It's caused by the partition rule change from DB. We shall fix it in a separate PR

@tisonkun
Copy link
Contributor

@waynexia CI failed to your recent PARTITION syntax change - GreptimeTeam/greptimedb#3347

Perhaps you can fix it also?

@tisonkun
Copy link
Contributor

Said now this sql is invalid:

	createTableSQL = `CREATE TABLE dist_table (
                        ts TIMESTAMP DEFAULT current_timestamp(),
                        n INT,
    					row_id INT,
                        TIME INDEX (ts),
                        PRIMARY KEY(n)
                     )
                     PARTITION BY RANGE COLUMNS (n) (
    				 	PARTITION r0 VALUES LESS THAN (5),
    					PARTITION r1 VALUES LESS THAN (9),
    					PARTITION r2 VALUES LESS THAN (MAXVALUE),
					)`

@tisonkun
Copy link
Contributor

tisonkun commented Mar 12, 2024

Or let's fix the e2e first in another PR first, then we can merge this PR ensuring the tests passed.

@waynexia
Copy link
Member Author

The e2e test failure seems unrelated to this change. It's caused by the partition rule change from DB. We shall fix it in a separate PR

That seems unrelated to this change. Maybe we should pin the db version in the e2e test to also prevent future breaking changes. As those CI are not run in the main repo against every new commit.

@tisonkun
Copy link
Contributor

That seems unrelated to this change. Maybe we should pin the db version in the e2e tes

Make sense. Anyway let's avoid merging patch without CI green if possible. (The failed test is unrelated, but it terminates following tests I guess?)

@waynexia
Copy link
Member Author

The failed test is unrelated, but it terminates following tests I guess?

For this specific case, SQL is run after the cluster is up.

@zyy17
Copy link
Collaborator

zyy17 commented Mar 12, 2024

@waynexia Are you fixing the failure of e2e test? If not, let me fix it in a sperate PR.

@waynexia
Copy link
Member Author

@waynexia Are you fixing the failure of e2e test? If not, let me fix it in a sperate PR.

Trying... #196

@daviderli614 daviderli614 mentioned this pull request Mar 14, 2024
@daviderli614
Copy link
Member

@waynexia The e2e failure will be fixed in this pr: #197
Can rebase it when merge.

@tisonkun tisonkun merged commit 6e4058c into develop Mar 14, 2024
10 checks passed
@tisonkun tisonkun deleted the fix-invalid-arg branch March 14, 2024 14:06
MichaelScofield pushed a commit to MichaelScofield/gtctl that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to parse address :0
5 participants