Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add replicas support for metasrv in bare-metal mode #145

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Aug 30, 2023

Closes: #138

@shawnh2 shawnh2 requested a review from zyy17 August 30, 2023 03:39
Signed-off-by: sh2 <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (6809b1c) 31.78% compared to head (e9a2cc8) 31.81%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #145      +/-   ##
===========================================
+ Coverage    31.78%   31.81%   +0.02%     
===========================================
  Files            9        9              
  Lines         1293     1292       -1     
===========================================
  Hits           411      411              
+ Misses         788      787       -1     
  Partials        94       94              
Files Changed Coverage Δ
pkg/cmd/gtctl/cluster/get/get.go 10.00% <0.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyy17 zyy17 merged commit 05d9130 into GreptimeTeam:develop Aug 30, 2023
6 checks passed
@shawnh2 shawnh2 deleted the add-meta-replica-mb branch August 30, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add replicas support for metasrv in bare-metal
3 participants