Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: support golangci-lint #130

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Aug 21, 2023

What's changed

  1. Add .golangci.yaml and make lint;

  2. Fix lint errors that are found by make lint;

  3. Refine GitHub Actions(multiple minor changes):

    • Use the latest Go version;
    • Refine naming: linter -> lint;
    • Use ncipollo/release-action@v1 as release workflow;
    • Update golangci-lint version;
    • Release gtctl by only creating a version tag and use ncipollo/release-action to release artifacts'(same as greptimedb actions);

Related issues

@zyy17 zyy17 requested review from shawnh2 and daviderli614 and removed request for shawnh2 August 21, 2023 09:11
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Merging #130 (0230fec) into develop (eb80cbd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #130   +/-   ##
========================================
  Coverage    22.02%   22.02%           
========================================
  Files            8        8           
  Lines          940      940           
========================================
  Hits           207      207           
  Misses         677      677           
  Partials        56       56           
Files Changed Coverage Δ
pkg/deployer/baremetal/artifacts.go 36.31% <ø> (ø)

Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyy17 zyy17 merged commit 1e37aff into GreptimeTeam:develop Aug 21, 2023
6 checks passed
@zyy17 zyy17 deleted the refactor/add-lint branch August 21, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants