Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve all the context handling in k8s creation #129

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Aug 21, 2023

Fixes #127

@shawnh2 shawnh2 requested a review from zyy17 August 21, 2023 08:49
@codecov-commenter
Copy link

Codecov Report

Merging #129 (4ac0c2f) into develop (eb80cbd) will decrease coverage by 0.09%.
The diff coverage is 20.00%.

@@             Coverage Diff             @@
##           develop     #129      +/-   ##
===========================================
- Coverage    22.02%   21.94%   -0.09%     
===========================================
  Files            8        8              
  Lines          940      948       +8     
===========================================
+ Hits           207      208       +1     
- Misses         677      683       +6     
- Partials        56       57       +1     
Files Changed Coverage Δ
pkg/cmd/gtctl/cluster/create/create.go 0.00% <0.00%> (ø)
pkg/helm/helm.go 33.33% <21.42%> (-1.38%) ⬇️

Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyy17 zyy17 merged commit 519bdff into GreptimeTeam:develop Aug 21, 2023
6 checks passed
@shawnh2 shawnh2 deleted the optim-kube-create branch August 21, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

imporve the creation of greptimedb cluster in kubernetes
3 participants