Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for bare-metal deployer #125

Merged
merged 6 commits into from
Aug 23, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Aug 14, 2023

related: #94

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Merging #125 (56ec99a) into develop (294be69) will increase coverage by 7.43%.
The diff coverage is 70.00%.

@@             Coverage Diff             @@
##           develop     #125      +/-   ##
===========================================
+ Coverage    21.94%   29.38%   +7.43%     
===========================================
  Files            8        8              
  Lines          948      953       +5     
===========================================
+ Hits           208      280      +72     
+ Misses         683      608      -75     
- Partials        57       65       +8     
Files Changed Coverage Δ
pkg/deployer/baremetal/deployer.go 35.46% <70.00%> (+35.46%) ⬆️

@shawnh2 shawnh2 requested a review from zyy17 August 16, 2023 12:10
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyy17 zyy17 merged commit 4b1566f into GreptimeTeam:develop Aug 23, 2023
6 checks passed
@shawnh2 shawnh2 deleted the test-for-bm branch August 23, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants