Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add RetainLogs support for bare-metal mode #116

Merged
merged 5 commits into from
Aug 8, 2023
Merged

feat: add RetainLogs support for bare-metal mode #116

merged 5 commits into from
Aug 8, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Aug 7, 2023

closes: #115

  • feat: add a --retain-logs knob for bare-metal
  • refactor: optimize the delete logic of each components

@shawnh2 shawnh2 requested a review from zyy17 August 7, 2023 10:57
zyy17
zyy17 approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pkg/cmd/gtctl/cluster/create/create.go Outdated Show resolved Hide resolved
@shawnh2 shawnh2 merged commit 342fc6f into GreptimeTeam:develop Aug 8, 2023
4 checks passed
@shawnh2 shawnh2 deleted the feat/add_retain_logs_4_bm branch August 8, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyy17 zyy17 zyy17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add RetainLogs options for bare-metal mode
2 participants
@shawnh2 @zyy17