Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: adapting incompatible changes from upstream release pipeline #113

Merged
merged 5 commits into from
Aug 7, 2023
Merged

refactor: adapting incompatible changes from upstream release pipeline #113

merged 5 commits into from
Aug 7, 2023

Conversation

zyy17
Copy link
Collaborator

@zyy17 zyy17 commented Aug 7, 2023 •
edited
Loading

Related issue: #107

  1. Adapting incompatible changes from upstream release pipeline;
  2. Refactor pkg/utils and add unit tests;
  3. Simplify some logic of artifacts.go(move to pkg/utils) and add unit tests for artifacts.go;

@zyy17 zyy17 requested a review from shawnh2 August 7, 2023 08:17
shawnh2
shawnh2 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@shawnh2 shawnh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shawnh2 shawnh2 merged commit 4fd6cfc into GreptimeTeam:develop Aug 7, 2023
4 checks passed
@zyy17 zyy17 deleted the refactor/simplify-am branch August 24, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnh2 shawnh2 shawnh2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zyy17 @shawnh2