Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add foreground deletion and refactor deployer for cluster in bare-metal mode #106

Merged
merged 6 commits into from
Aug 3, 2023
Merged

feat: add foreground deletion and refactor deployer for cluster in bare-metal mode #106

merged 6 commits into from
Aug 3, 2023

Conversation

shawnh2
Copy link
Contributor

@shawnh2 shawnh2 commented Jul 28, 2023 •
edited
Loading

for bare-metal mode:

  • refactor deployer
    • seperate config and validation logic
    • seperate each cluster componments logic
  • for create cmd
    • add the foreground deletion
    • enable timeout context for deployment

@zyy17
Copy link
Collaborator

zyy17 commented Jul 31, 2023

@shawnh2 seems ci failed.

zyy17
zyy17 reviewed Aug 2, 2023
View reviewed changes
pkg/cmd/gtctl/cluster/create/create.go Show resolved Hide resolved
pkg/deployer/baremetal/component/cluster.go Outdated Show resolved Hide resolved
pkg/deployer/baremetal/component/cluster.go Outdated Show resolved Hide resolved
pkg/deployer/baremetal/component/cluster.go Outdated Show resolved Hide resolved
pkg/deployer/baremetal/component/datanode.go Show resolved Hide resolved
pkg/deployer/baremetal/component/frontend.go Show resolved Hide resolved
zyy17
zyy17 approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@zyy17 zyy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyy17 zyy17 merged commit 4151288 into GreptimeTeam:develop Aug 3, 2023
4 checks passed
@shawnh2 shawnh2 deleted the feat/bare-metal-delete branch August 3, 2023 08:17
@shawnh2 shawnh2 mentioned this pull request Aug 3, 2023
Merged
@shawnh2 shawnh2 mentioned this pull request Jul 27, 2023
Closed
4 tasks
@shawnh2
Copy link
Contributor Author

shawnh2 commented Aug 25, 2023

related to #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyy17 zyy17 zyy17 approved these changes

@daviderli614 daviderli614 Awaiting requested review from daviderli614

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawnh2 @zyy17