Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
confoc committed May 22, 2024
1 parent 6654855 commit 98e56c4
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
6 changes: 1 addition & 5 deletions cmd/gtctl/cluster_create.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,15 +180,11 @@ func NewCluster(args []string, options *clusterCreateCliOptions, l logger.Logger
}

var cluster opt.Operations

if options.BareMetal {

l.V(0).Infof("Creating GreptimeDB cluster '%s' on bare-metal", logger.Bold(clusterName))

var opts []baremetal.Option
opts = append(opts, baremetal.WithEnableCache(options.EnableCache))
opts = append(opts, baremetal.WithEnableEtcd(options.EnableEtcd))

opts = append(opts, baremetal.WithEnableCache(options.EnableCache), baremetal.WithEnableEtcd(options.EnableEtcd))
if len(options.GreptimeBinVersion) > 0 {
opts = append(opts, baremetal.WithGreptimeVersion(options.GreptimeBinVersion))
}
Expand Down
2 changes: 0 additions & 2 deletions pkg/components/metasrv.go
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ CHECKER:
}

func (m *metaSrv) BuildArgs(params ...interface{}) []string {

logLevel := m.config.LogLevel
if logLevel == "" {
logLevel = DefaultLogLevel
Expand All @@ -125,7 +124,6 @@ func (m *metaSrv) BuildArgs(params ...interface{}) []string {
fmt.Sprintf("--server-addr=%s", m.config.ServerAddr),
}
args = GenerateAddrArg("--http-addr", m.config.HTTPAddr, nodeID, args)

args = GenerateAddrArg("--bind-addr", bindAddr, nodeID, args)

if len(m.config.Config) > 0 {
Expand Down
1 change: 0 additions & 1 deletion tests/e2e/greptimedbcluster_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ func getCluster() error {
cmd := exec.Command("../../bin/gtctl", "cluster", "get", "mydb")
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr

if err := cmd.Run(); err != nil {
return err
}
Expand Down

0 comments on commit 98e56c4

Please sign in to comment.